Dropped ??? in arrayclass #567
Conversation
The patch caused the built dotty not to run anymore. Since the prupose of the ??? was to find out where it was called I inserted the stacktrace that caused dotc to fail. I wonder how this passed the tests? Dotc became completely useless for me when I ran it from the command line.
|
This passed tests, as you have a different classpath setup. |
| // Exception in thread "main" scala.NotImplementedError: an implementation is missing | ||
| // at scala.Predef$.$qmark$qmark$qmark(Predef.scala:225) | ||
| // at scala.runtime.ScalaRunTime$.arrayClass(ScalaRunTime.scala:53) | ||
| // at scala.Array$.fill(Array.scala:281) |
There was a problem hiding this comment.
Which version of scala-library do you have? I do not see any usage of arrayClass in Array.scala:281.
It's in now. |
|
I still do not see how this method is used and for what. It seems to be some pre-classTag thing, as it duplicates functionality available there. As I do not see a way of fixing this method to work for value classes, I want to understand what is it currently used for and see if we can replace all of its usages by equivalent usage of |
The patch caused the built dotty not to run anymore. Since the prupose of the ???
was to find out where it was called I inserted the stacktrace that caused dotc
to fail.
I wonder how this passed the tests? Dotc became completely useless for me when I
ran it from the command line.
Review by @DarkDimius. (Let's get this in quickly. I cannot pull anymore without this fix being in).